C17 Otters - Ying Goings + Liqing Li#41
Open
yinggoings wants to merge 11 commits intoada-c17:masterfrom
Open
Conversation
jbieniosek
reviewed
Apr 8, 2022
jbieniosek
left a comment
jbieniosek
left a comment
There was a problem hiding this comment.
Great work on this project Liqing and Ying! I am a huge fan of your PLAN.md doc, and I am going to suggest that as an addition to the project for future cohorts. Very clean, readable code in this project! Nice work with frequent commits - I did notice that there is only one commit that adds both waves 2 & 3, in the future I recommend adding a few more commits as you're progressing through waves of a project. This project is green.
Comment on lines
+80
to
+85
| while len(letters_drawn) < 10: | ||
| letter_drawn = random.choice(letter_options) | ||
| if letter_pool_copy[letter_drawn] >= 1: | ||
| letters_drawn.append(letter_drawn) | ||
| letter_pool_copy[letter_drawn] -= 1 | ||
| return letters_drawn |
| for char in upper_word: | ||
| if not char_counts[char]: | ||
| return False | ||
| char_counts[char] -= 1 |
There was a problem hiding this comment.
Neat solution! How would you solve this if you didn't have the Counter package?
| points += POINT_SYSTEM[char.upper()] | ||
| if len(word) >= 7 and len(word) <= 10: | ||
| points += 8 | ||
| return points |
Comment on lines
+111
to
+113
| if score_word(word) == max_score and len(max_word) != 10: | ||
| if len(word) == 10 or len(word) < len(max_word): | ||
| max_word = word |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.