Whales C17- Nishat Salsabil and Julie Warren Adagrams #43
Open
nishatsalsabil wants to merge 9 commits intoada-c17:masterfrom
Open
Whales C17- Nishat Salsabil and Julie Warren Adagrams #43nishatsalsabil wants to merge 9 commits intoada-c17:masterfrom
nishatsalsabil wants to merge 9 commits intoada-c17:masterfrom
Conversation
…e_02 tests; wave_02 complete
jericahuang
reviewed
Apr 8, 2022
jericahuang
left a comment
jericahuang
left a comment
There was a problem hiding this comment.
Great work on this project, Nish and Julie! The code you wrote together both passed all the tests and met the learning goals. I also made note of great highlights I saw. You both have earned a 🟢 on Adagrams!
| def draw_letters(): | ||
| pass | ||
| ''' | ||
| input: none |
| each letter in the LETTER_POOL | ||
| ''' | ||
| hand = [] | ||
| letter_freq = {} |
There was a problem hiding this comment.
Excellent use of a dictionary to keep track of letters and their frequencies
| False otherwise or if char in word is not in hand. | ||
| ''' | ||
| word = word.upper() | ||
| hand_copy = copy.deepcopy(hand) |
| output: Returns True if each char is uniquely in hand. Returns | ||
| False otherwise or if char in word is not in hand. | ||
| ''' | ||
| word = word.upper() |
There was a problem hiding this comment.
Nice! This will not introduce a side effect because strings are immutable!
| played_word_dict[word] = score | ||
|
|
||
| highest_score = max(played_word_dict.values()) | ||
| best_word_list = [key for key, value in played_word_dict.items()\ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.