Skip to content

Switch from flake8 and black to ruff, upgrade dependencies #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -4,12 +4,11 @@ requirements:

.PHONY: check
check:
black --check .
ruff .
ruff check .

.PHONY: format
format:
black .
ruff format .

.PHONY: coverage
coverage:
8 changes: 7 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -8,14 +8,20 @@ target-version = ['py38']
skip-string-normalization = true

[tool.ruff]
select = ["E", "F"]
line-length = 88
target-version = "py38"
exclude = [
".git",
".ruff_cache",
]

[tool.ruff.format]
quote-style = "single"

[tool.ruff.lint]
select = ["E", "F"]
ignore = ["E501"]

[tool.cibuildwheel]
build = [
"cp38-*",
2 changes: 1 addition & 1 deletion requirements/base.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# What we want
cffi==1.15.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enable dependabot in another PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check it out, yeah.

cffi==1.16.0

# What we need
pycparser==2.21
64 changes: 29 additions & 35 deletions requirements/development.txt
Original file line number Diff line number Diff line change
@@ -1,45 +1,40 @@
# What we want
build==0.10.0
black==23.3.0
cffi==1.15.1
coverage==7.2.5
ruff==0.0.267
setuptools==67.7.2
Sphinx==7.0.0
twine==4.0.2
wheel==0.40.0
build==1.1.1
coverage==7.4.3
ruff==0.3.2
setuptools==69.1.1
Sphinx==7.1.2
twine==5.0.0
wheel==0.43.0

# What we need
alabaster==0.7.13
Babel==2.12.1
bleach==6.0.0
certifi==2023.5.7
charset-normalizer==3.1.0
click==8.1.3
docutils==0.19
idna==3.4
Babel==2.14.0
certifi==2024.2.2
cffi==1.16.0
charset-normalizer==3.3.2
docutils==0.20.1
idna==3.6
imagesize==1.4.1
importlib-metadata==6.6.0
jaraco.classes==3.2.3
Jinja2==3.1.2
keyring==23.13.1
markdown-it-py==2.2.0
MarkupSafe==2.1.2
importlib_metadata==7.0.2
jaraco.classes==3.3.1
Jinja2==3.1.3
keyring==24.3.1
markdown-it-py==3.0.0
MarkupSafe==2.1.5
mdurl==0.1.2
more-itertools==9.1.0
mypy-extensions==1.0.0
packaging==23.1
pathspec==0.11.1
pkginfo==1.9.6
platformdirs==3.5.1
more-itertools==10.2.0
nh3==0.2.15
packaging==24.0
pkginfo==1.10.0
pycparser==2.21
Pygments==2.17.2
pyproject_hooks==1.0.0
Pygments==2.15.1
readme-renderer==37.3
requests==2.30.0
readme_renderer==43.0
requests==2.31.0
requests-toolbelt==1.0.0
rfc3986==2.0.0
rich==13.3.5
rich==13.7.1
six==1.16.0
snowballstemmer==2.2.0
sphinxcontrib-applehelp==1.0.4
@@ -48,8 +43,7 @@ sphinxcontrib-htmlhelp==2.0.1
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5
urllib3==2.0.2
webencodings==0.5.1
zipp==3.15.0
urllib3==2.2.1
zipp==3.17.0

-r base.txt
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -2,6 +2,6 @@

setup(
cffi_modules=[
"./ada_url/ada_build.py:ffi_builder",
'./ada_url/ada_build.py:ffi_builder',
],
)
1 change: 1 addition & 0 deletions update_ada.py
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
Run this script to pull in the latest version of `ada-url/ada` single
header package.
"""

from io import BytesIO
from os.path import dirname, join
from zipfile import ZipFile