Better handle RTD build status checking#409
Merged
FoamyGuy merged 1 commit intoadafruit:mainfrom Mar 20, 2026
Merged
Conversation
tekktrik
force-pushed
the
dev/rtd-check-improvements
branch
from
de260bd to
3fbf7fe
Compare
FoamyGuy
approved these changes
Mar 20, 2026
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Looks like good fallback to me. Thank you
Contributor
|
Not sure why but the pytest action failed after this was merged. Logs here https://github.com/adafruit/adabot/actions/runs/23345992986/job/67912221554#step:6:59 make it seems like some of the repo data isn't including certain keys. Very strange though because I don't think this change is in an area of code that would have any impact on that. Maybe transient issue with github API or a token issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was some old changes I had in my repo that I meant to PR. If I remember correctly, there were some weird errors to checking the status of ReadTheDocs builds, so I added more flexibility to the check to not crash if it either couldn't retrieve the slug or actual build status.