Update inputs to be numeric; allow updating BPM with keyboard arrows while playing #1
Open
jwenerd wants to merge 4 commits intoadamcogen:mainfrom
Open
Update inputs to be numeric; allow updating BPM with keyboard arrows while playing #1jwenerd wants to merge 4 commits intoadamcogen:mainfrom
jwenerd wants to merge 4 commits intoadamcogen:mainfrom
Conversation
jwenerd
force-pushed
the
feature/input-number-bpm-slide
branch
from
2c33024 to
fa18a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the inputs to be input[type="number] which allows for changing the value by pressing the up or down arrow.
While holding shift and pressing key up/down on the BPM input - change the tempo of playback immediately. Feature allows rapid changing and sliding of tempo.
Including some rework of how these elements are generated.