Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*:skip) Improve update_changelog.py to include all contributors and make it faster #4912

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Feb 5, 2025

Why This PR

@dstripelis discovered that some co-authors of a PR were being ignored when collecting all contributor names. Additionally, update_changelog.py was too slow due to an I/O bottleneck.

What This Does

  • Retrieves GitHub usernames of co-authors from auto-generated commit messages and finds their full names based on these usernames.
  • Replaces GitHub API calls with local Git equivalents wherever possible.
  • Speeds up GitHub API calls using multi-threading.

@panh99 panh99 changed the title ci(*) Improve update_changelog.py to include all contributors and make it faster feat(ci) Improve update_changelog.py to include all contributors and make it faster Feb 5, 2025
@panh99 panh99 changed the title feat(ci) Improve update_changelog.py to include all contributors and make it faster ci(*:skip) Improve update_changelog.py to include all contributors and make it faster Feb 5, 2025
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
@panh99 panh99 marked this pull request as ready for review February 6, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants