-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(*:skip) Improve update_changelog.py
to include all contributors and make it faster
#4912
Open
panh99
wants to merge
9
commits into
main
Choose a base branch
from
better-update-changelog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panh99
changed the title
ci(*) Improve
feat(ci) Improve Feb 5, 2025
update_changelog.py
to include all contributors and make it fasterupdate_changelog.py
to include all contributors and make it faster
panh99
changed the title
feat(ci) Improve
ci(*:skip) Improve Feb 5, 2025
update_changelog.py
to include all contributors and make it fasterupdate_changelog.py
to include all contributors and make it faster
dstripelis
requested changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why This PR
@dstripelis discovered that some co-authors of a PR were being ignored when collecting all contributor names. Additionally,
update_changelog.py
was too slow due to an I/O bottleneck.What This Does