Repository navigation
Fix: Menu background image lost at extra large screen sizes after migration (fixes #244) - #245
Merged
Merged
Conversation
oliverfoster
approved these changes
Oct 7, 2026
oliverfoster
left a comment
oliverfoster
left a comment
Member
There was a problem hiding this comment.
Brad, a man whose calm under pressure is the stuff of quiet legend.
Migration suite passes on this branch (23/23, via grunt migration:test --file=adapt-contrib-boxMenu). The new populated-content case carries _large into _xlarge for the course, menu header and sub-menu backgrounds.
The ">= → >= fixes to the updatePlugin framework ranges look right.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
## [7.7.1](v7.7.0...v7.7.1) (2026-10-07) ### Chore * README metadata (fixes #240) #241 ([a431941](a431941)), closes [#240](#240) [#241](#241) ### Fix * Menu background image lost at extra large screen sizes after migration (fixes #244) (#245) ([fe1e62e](fe1e62e)), closes [#244](#244) [#245](#245) [#244](#244)
|
🎉 This PR is included in version 7.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244
Fix
updatePlugincall across the migrations. All six were affected, so a migrated course was being given a malformed range such as">=5.24.2instead of>=5.24.2. The corrected values match the framework fields in the corresponding releases.Testing
Full migration suite passes (23 tests). Reverting only the change to the two mutate steps, while keeping the new check and test, makes the suite fail — so the new test genuinely exercises the fix rather than passing regardless.
Migrating a course that sets a menu background image gives:
Notes
Found while reviewing adaptlearning/adapt-contrib-vanilla#616, which had the same problem in its new migration scripts.
adapt-contrib-languagePicker uses the same breakpoint fallback but is not affected — there the background image and the extra large option arrived in the same release, so there is never an earlier large value to carry over.
Posted via collaboration with Claude Code