Skip to content

Defensive guard for missing _globals in mediaLibrariesOverrides #369

Closed

Description

@taylortom

mediaLibrariesOverrides.js reads Adapt.course.get('_globals')?._components?._media without guarding against the _media key being absent.

If _globals._components._media is undefined, the property access throws on app:dataReady, aborting the synchronous event dispatch for subsequent listeners. Suggest adding a ?? {} fallback to degrade gracefully.

Activity

  1. self-assigned this
    on Jun 5, 2026
  2. moved this from New to Needs Reviewing in adapt_framework: The TODO Boardon Jun 5, 2026
  3. added theissue type on Jun 11, 2026
  4. added a commit that references this issue on Aug 5, 2026
    9fcce6b
  5. moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Boardon Aug 5, 2026
  6. added a commit that references this issue on Aug 5, 2026
    3383208
  7. github-actions commented on Aug 5, 2026

    @github-actions

    🎉 This issue has been resolved in version 7.1.1 🎉

    The release is available on GitHub release

    Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions