Repository navigation
Conversation
ethan-lp
approved these changes
Sep 16, 2026
kirsty-hames
approved these changes
Sep 16, 2026
kirsty-hames
left a comment
kirsty-hames
left a comment
Contributor
There was a problem hiding this comment.
Great spot thanks @swashbuck 👍 New contrast confirmed as 5:15
lemmyadams
approved these changes
Sep 28, 2026
|
🎉 This PR is included in version 9.41.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #618
Darkens
@validation-errorfrom#ff0000to#dd0000, taking its contrast against white from 4.00:1 to 5.15:1 and clearing the 4.5:1 WCAG AA needs for normal-size text.@validation-error-invertedtext when showing an incorrect answer, so the learner's selected number was below AA.#dd0000was chosen over the lightest passing value,#ee0000(4.53:1), to leave headroom. A margin of 0.03 is fragile behind text, where thin glyphs and sub-pixel rendering perform worse than the raw ratio suggests.@validation-success(#065f28, 7.85:1), which was already darkened for contrast.@validation-error-invertedis unchanged; white on#dd0000passes.box-shadowuse in matching.less is unaffected, as a non-text indicator only needs 3:1.Posted via collaboration with Claude Code