fix: use Promise.allSettled for multi-agent partial failure handling #198
+295
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug: When using
AgentCollectionmethods (e.g.,allAgents().getProducts()) across multiple agents, if any single agent threw an exception,Promise.allwould reject immediately and discard all results—even from agents that succeeded.Fix: Replace
Promise.allwithPromise.allSettledso that:TaskResultwithsuccess: false, the error message, and agent metadataChanges:
executeAllSettledprivate method for consistent partial failure handlingAgentCollectiontask methods to useexecuteAllSettledexecute()to returnPromiseSettledResult[]for custom executorsTest plan
npm run build)execute()returnsPromiseSettledResultarray