fix: normalize v2 pricing options before schema validation #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When servers return v2-style pricing options (rate, is_fixed, price_guidance.floor), schema validation was failing because it expected v3 fields (fixed_price, floor_price). This fix adds normalization before validation in TaskExecutor, ensuring v2 server responses pass validation against v3 schemas. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
force-pushed
the
bokelley/adcp-v3-upgrade
branch
from
be6210d to
f6fe90e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rate,is_fixed,price_guidance.floor) are now converted to v3 format (fixed_price,floor_price) before schema validationProblem
When calling
get_productsagainst v2 servers (like test-agent.adcontextprotocol.org), schema validation was failing with errors like:The root cause was that validation ran BEFORE the v2→v3 normalization that happens in
SingleAgentClient.normalizeResponseToV3().Solution
Added
normalizeResponseForValidation()method inTaskExecutorthat normalizes responses before schema validation. This reuses the existingnormalizeGetProductsResponse()utility frompricing-adapter.ts.Test plan
🤖 Generated with Claude Code