Fix Addie testing tools: remove call_adcp_tool, add setup_test_agent #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause: Addie was hallucinating wrong credentials and parameter formats when using the call_adcp_tool meta-tool, because it had to guess at MCP schema structures. Changes: - Remove call_adcp_tool: Meta-tool approach allowed LLM to hallucinate params - Add setup_test_agent: One-click setup saves test agent with correct token - Update test_adcp_agent: Now requires agents to be saved first via setup_test_agent (public) or save_agent (custom agents) - Clean up usage hints to remove references to removed tool The new flow enforces correct credential handling by requiring users to save agents before testing, using the existing save_agent infrastructure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
call_adcp_toolmeta-tool that allowed Addie to hallucinate incorrect credentials and parameter formatssetup_test_agentfor one-click setup of the public test agent with correct credentialstest_adcp_agentto require agents to be saved first (enforces correct credential handling)Root cause: When testing the public test agent, Addie hallucinated
dGVzdDp0ZXN0MTIz(base64 oftest:test123) instead of the actual bearer token, and passed flat params toget_productsinstead of nested infilters.Fix: Remove the meta-tool approach that allowed guessing at MCP schema structures. Users must now save agents (with correct credentials) before testing.
Test plan
🤖 Generated with Claude Code