Fix Discover Events nudge when no events exist #631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the "Discover Events" nudge when: - There are no upcoming events in the database - User is already registered for all upcoming events This prevents confusing nudges like suggesting users discover events when there are none to discover. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The "Discover Events" nudge was being recommended to users even when:
This led to confusing outreach like suggesting Christina discover events when there are none to discover.
Solution
Added
filterDynamicEligibility()to the outbound planner that checks:eventsDb.getUpcomingEvents())eventsDb.getUserRegistrations())If either condition is true, the "Discover Events" goal is filtered out before goal selection.
Test plan
npm run typecheck)npm test)🤖 Generated with Claude Code