-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Add typed extensions infrastructure with auto-discovery #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,074
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
093eaec to
8880f6d
Compare
Typed extensions provide formal JSON schemas for vendor-agnostic
extension data in `ext.{namespace}` fields. This enables SDK code
generation, schema validation, and cross-vendor interoperability.
**New features:**
- Extension meta schema defining valid_from/valid_until version bounds
- Auto-discovery of extensions during schema build
- Version-filtered extension registries per schema version
- New `extensions_supported` field in agent card adcp extension
- Comprehensive test suite for extension infrastructure
**How it works:**
1. Extensions are defined in `/schemas/source/extensions/{namespace}.json`
2. Build script auto-discovers extensions and filters by version compatibility
3. Each versioned build includes only compatible extensions in registry
4. Agents declare supported extensions via `extensions_supported` array
This is a MINOR release adding new optional capabilities without
breaking existing functionality.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
8880f6d to
e8b4e17
Compare
youbek
reviewed
Jan 8, 2026
youbek
reviewed
Jan 8, 2026
youbek
reviewed
Jan 8, 2026
Updates documentation to be compliant with both protocol specs: **A2A Agent Cards:** - Changed from `extensions.adcp` object to proper A2A `extensions[]` array format - Each extension now has uri, description, required, and params fields - Extension URI: https://adcontextprotocol.org/extensions/adcp **MCP Server Cards:** - Added support for declaring AdCP via `_meta['adcontextprotocol.org']` - Supports both `/.well-known/mcp.json` and `/.well-known/server.json` - Uses reverse DNS namespacing per MCP server.json spec **Extension Params Schema:** - Updated description to clarify usage in both protocols - Same params structure works for both A2A and MCP 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The JSON schema validation test was failing because it tried to validate against https://registry.modelcontextprotocol.io/server.schema.json which is an external schema we don't have locally. Removed the $schema field from MCP server card examples since they reference an external MCP registry schema, not an AdCP schema. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
BaiyuScope3
reviewed
Jan 8, 2026
BaiyuScope3
reviewed
Jan 8, 2026
BaiyuScope3
approved these changes
Jan 8, 2026
Collaborator
BaiyuScope3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses PR review feedback: **Reserved Namespaces (@BaiyuScope3)** - Added RESERVED_NAMESPACES list: adcp, core, protocol, schema, meta, ext, context - Build script now validates and rejects reserved namespaces - Documented in extensions reference **Deprecation Policy (@BaiyuScope3)** - Added "Extension Deprecation Policy" section with: - When extensions may be deprecated (superseded, promoted, low adoption, incompatible) - Standard deprecation process (valid_until + 1 minor, CHANGELOG, migration guide) - Emergency deprecation for security issues **Tests** - Added test verifying reserved namespaces are not used 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ext.{namespace}fieldsvalid_from/valid_untilextensions_supportedfield to agent card for declaring typed extension supportFeatures
Extension Meta Schema (
extension-meta.json)valid_from(required): Minimum AdCP version (e.g., "2.5")valid_until(optional): Maximum AdCP version for deprecationAuto-Discovery Build System
/schemas/source/extensions/{namespace}.jsonare auto-discoveredextensions/index.json) is auto-generated with valid extensionsAgent Card Extension Support
extensions_supportedarray field in adcp extensionHow It Works
/schemas/source/extensions/{namespace}.jsonvalid_fromspecifying minimum AdCP versionextensions_supported: ["namespace"]ext.{namespace}data against typed schemasTest plan
npm run test:extension-schemaspassesextensions_supportedfield🤖 Generated with Claude Code