fix: resolve duplicate members and missing leader actions on chapter pages #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pages Fixed two issues reported by David Porzelt on the German chapter page: 1. Duplicate members in chapter lists - Users belonging to multiple organizations appeared multiple times due to a SQL JOIN that returned multiple rows per user. Fixed by using LEFT JOIN LATERAL with LIMIT 1 to ensure only one organization membership row per user. 2. Leader actions not working - The /api/config endpoint was not returning the user's ID, causing the frontend leader check to always fail since currentUser.id was undefined. Added id field to the response. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Bug 1 - Duplicate Members: SQL queries in
working-group-db.tsusedLEFT JOIN organization_membershipswhich returned multiple rows when a user belongs to multiple organizations. David Porzelt appeared twice because he's a member of 2 organizations.Bug 2 - Missing Leader Actions: The
/api/configendpoint wasn't returning the user'sidfield. The frontend checkscurrentUser.id === leader.user_id, butcurrentUser.idwas alwaysundefined.Changes
server/src/db/working-group-db.ts: Changed plainLEFT JOIN organization_membershipstoLEFT JOIN LATERAL ... LIMIT 1in three queries:getMembershipsByWorkingGroup()getLeaders()getLeadersBatch()server/src/http.ts: Addedid: req.user.idto the/api/configresponseTest plan
🤖 Generated with Claude Code