feat: update to adcp 2.18.0 with new assets field support #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade adcp dependency from 2.17.0 to 2.18.0 - Add backward compatibility for list_creative_formats tool - Populate assets_required from assets for old clients - Populate assets from assets_required for old formats - Use adcp.utils.format_assets utilities (get_format_assets, has_assets, uses_deprecated_assets_field) for consistent asset handling - Update tests to use new Assets type instead of deprecated AssetsRequired - Update media_buy_create to use get_format_assets utility This ensures both old buyer agents (using assets_required) and new buyer agents (using assets) can work with the sales agent.
- urllib3: 2.6.2 -> 2.6.3 (GHSA-38jv-5279-wg99) - werkzeug: 3.1.4 -> 3.1.5 (GHSA-87hc-h4r5-73f7)
- Use TypeVar in _ensure_backward_compatible_format to preserve Format subtype - Use get_individual_assets() instead of get_format_assets() in media_buy_create - Add isinstance type guard for Assets to satisfy mypy union type checks
1. Schema validation tests (extra='allow' change): - adcp 2.18.0 changed library schemas to use extra='allow' for forward compat - Updated tests to verify extra fields are accepted but ignored - Renamed tests to reflect new behavior (rejects -> ignores) 2. A2A response extraction (TextPart + DataPart pattern): - A2A responses may now have TextPart before DataPart - Added extract_data_from_artifact helper to find DataPart - Updated tests to handle variable part ordering
BaiyuScope3
commented
Jan 9, 2026
BaiyuScope3
commented
Jan 9, 2026
get_individual_assets() returns ALL individual assets (required + optional), not just required ones. Renamed variable to avoid confusion.
…traction Added comments to make clear that get_individual_assets() maintains the same behavior as before - repeatable groups were never supported here.
BaiyuScope3
commented
Jan 9, 2026
BaiyuScope3
commented
Jan 9, 2026
bokelley
approved these changes
Jan 10, 2026
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the sales agent to support AdCP-client 2.18.0's new
assetsfield while maintaining backward compatibility with older clients that use the deprecatedassets_requiredfield.Per
AdCP protocol 2.6.0spec.Motivation
AdCP-client 2.18.0 introduces a new
assetsfield in theFormatschema that includes both required and optional assets (with an explicitrequired: booleanflag). The previousassets_requiredfield only contained required assets and is now deprecated.This change ensures:
assets_requiredassetsfield with optional asset supportChanges
Core Changes
pyproject.toml: Upgradedadcp client pythonfrom 2.17.0 to 2.18.0src/core/tools/creative_formats.py:_ensure_backward_compatible_format()function that ensures both fields are populatedhas_assets,uses_deprecated_assets_field,get_format_assets, etc.)assets→ populatesassets_requiredfrom required assetsassets_required→ populatesassetsusingnormalize_assets_required()src/core/tools/media_buy_create.py: Updated to useget_format_assets()utility for consistent asset handlingTest Updates
tests/helpers/adcp_factories.pyto use newAssetstypeassetsfield instead of deprecatedassets_requiredBackward Compatibility
assets(new)assets_required(old)Testing
Test sales agent MCP tools