fix: Improve onboarding experience and resolve first-run issues #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Docker volume naming to `adcp_` prefix to avoid conflicts with other Postgres containers
- Fix brand_manifest_policy model default to match migration (require_auth)
- Demo tenant now uses public policy for easier quick start testing
- Fix landing page redirect from /admin/tenant/{id} to /tenant/{id}
- Unify documentation between Quick Start and Development Setup guides
- Update login instructions to match single-tenant mode defaults
- Add comprehensive troubleshooting section for common startup issues
🤖 Generated with Claude Code
Co-Authored-By: Claude Haiku 4.5 <[email protected]>
- urllib3: 2.6.2 → 2.6.3 (GHSA-38jv-5279-wg99) - Werkzeug: 3.1.4 → 3.1.5 (GHSA-87hc-h4r5-73f7) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The test_media_buy_create_helpers.py test was making real network calls to creative.adcontextprotocol.org which caused flaky failures when the service was unavailable. Unit tests should mock external dependencies. - Mock get_creative_agent_registry instead of making real network calls - Add test for unknown format returns None - Add test for exception handling returns None Co-Authored-By: Claude Opus 4.5 <[email protected]>
- filelock: 3.20.1 → 3.20.3 (GHSA-qmgc-5h2g-mvrw) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The creative assignment E2E tests depend on the external creative agent service (creative.adcontextprotocol.org). When this service is unavailable or returns empty formats, the tests should skip rather than fail. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Resolve conflict in tests/unit/test_media_buy_create_helpers.py by combining both versions - keeping MagicMock and the additional test_exception_returns_none test case. Co-Authored-By: Claude Opus 4.5 <[email protected]>
BaiyuScope3
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes six critical onboarding issues reported by first-time users, including Docker volume conflicts, authentication policy mismatches, routing errors, documentation inconsistencies, and unclear login instructions.
Changes
adcp_prefix to avoid conflicts with other projectsbrand_manifest_policymodel/migration mismatch; demo tenant uses public policy for easy testing/tenant/{id}route instead of 404Testing
All 1380 unit tests, 33 integration tests, and 8 integration_v2 tests pass. Pre-commit hooks validated.
🤖 Generated with Claude Code
Co-Authored-By: Claude Haiku 4.5 [email protected]