Skip to content

docs: add PR-overlap guideline to CLAUDE.md#325

Merged
addyosmani merged 1 commit into
addyosmani:mainfrom
nucliweb:docs/pr-overlap-guideline
Jun 28, 2026
Merged

docs: add PR-overlap guideline to CLAUDE.md#325
addyosmani merged 1 commit into
addyosmani:mainfrom
nucliweb:docs/pr-overlap-guideline

Conversation

@nucliweb

Copy link
Copy Markdown
Collaborator

What

Adds a ## Pull Requests section and a Boundaries bullet to CLAUDE.md: before opening a PR, search the upstream repo's open PRs and issues for overlapping work, and coordinate instead of opening a conflicting PR. It also nudges toward small, focused PRs over large refactors of widely shared files.

Why

There was no guidance to check for in-flight work before opening a PR, and it bit us in practice: #324 was opened without noticing #323, which was already open against the same file (scripts/validate-skills.js) and overlapping on the same rule (the description "when to use" trigger). The result is a guaranteed merge conflict and duplicated effort that a quick scan of open PRs would have prevented.

The wording is intentionally generic about remote names (origin / upstream are mentioned only as the common convention) so it applies regardless of how a contributor's remotes are set up.

Scope

Docs only. No code or validator behavior changes.

… a PR

Add a Pull Requests section and a Boundaries bullet to CLAUDE.md: before
opening a PR, search the upstream repo's open PRs and issues for overlapping
work and coordinate instead of opening a conflicting PR. Wording is generic
about remote names so it applies regardless of fork setup.
@nucliweb

Copy link
Copy Markdown
Collaborator Author

Hi @addyosmani @federicobartoli, could you take a look when you have a moment?

@addyosmani

Copy link
Copy Markdown
Owner

Merging. Sensible anti-overlap guideline that codifies the coordinate-before-you-open-a-PR habit we've needed. Thanks @nucliweb.

@addyosmani
addyosmani merged commit b01a145 into addyosmani:main Jun 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants