Add design review skills and wire them into the review flow#335
Open
ahmedalaahagag wants to merge 4 commits into
Open
Add design review skills and wire them into the review flow#335ahmedalaahagag wants to merge 4 commits into
ahmedalaahagag wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR makes the design-review path in
agent-skillsexplicit and self-contained.It:
lightweight-design-analysissoftware-design-principlescode-review-and-qualityusing-agent-skillsso the discovery flow, lifecycle examples, and quick reference all include the new review skillsWhy
The existing review skill already covered architecture and readability, but the design-review path was implicit. This change makes that path explicit without changing the core five-axis review model.
The follow-up skill additions also make the PR self-contained: reviewers do not need extra local setup or separately installed skills for the new review path to make sense.
Scope
Intentionally included:
skills/code-review-and-quality/SKILL.mdskills/lightweight-design-analysis/SKILL.mdskills/software-design-principles/SKILL.mdskills/using-agent-skills/SKILL.mdREADME.mdIntentionally excluded:
/shipand persona changesValidation
skills/code-review-and-qualityreferences both skillsusing-agent-skillsdiscovery and quick reference mention both skillsmain