Skip to content

Add design review skills and wire them into the review flow#335

Open
ahmedalaahagag wants to merge 4 commits into
addyosmani:mainfrom
ahmedalaahagag:local/code-review-design-hooks
Open

Add design review skills and wire them into the review flow#335
ahmedalaahagag wants to merge 4 commits into
addyosmani:mainfrom
ahmedalaahagag:local/code-review-design-hooks

Conversation

@ahmedalaahagag

@ahmedalaahagag ahmedalaahagag commented Jun 28, 2026

Copy link
Copy Markdown

What changed

This PR makes the design-review path in agent-skills explicit and self-contained.

It:

  • adds two repo-native review skills:
    • lightweight-design-analysis
    • software-design-principles
  • wires those skills into code-review-and-quality
  • updates using-agent-skills so the discovery flow, lifecycle examples, and quick reference all include the new review skills
  • updates the README skill catalog and count

Why

The existing review skill already covered architecture and readability, but the design-review path was implicit. This change makes that path explicit without changing the core five-axis review model.

The follow-up skill additions also make the PR self-contained: reviewers do not need extra local setup or separately installed skills for the new review path to make sense.

Scope

Intentionally included:

  • skills/code-review-and-quality/SKILL.md
  • skills/lightweight-design-analysis/SKILL.md
  • skills/software-design-principles/SKILL.md
  • skills/using-agent-skills/SKILL.md
  • README.md

Intentionally excluded:

  • /ship and persona changes
  • marketplace/plugin wiring changes
  • broader docs beyond the README catalog update

Validation

  • verified the repo now contains both new skill files under skills/
  • verified code-review-and-quality references both skills
  • verified using-agent-skills discovery and quick reference mention both skills
  • kept the work as focused commits on top of current main

@ahmedalaahagag ahmedalaahagag marked this pull request as ready for review June 28, 2026 11:02
@ahmedalaahagag ahmedalaahagag marked this pull request as draft June 28, 2026 11:05
@ahmedalaahagag ahmedalaahagag changed the title Add design analysis hooks to code review skill Add design review skills and wire them into the review flow Jun 28, 2026
@ahmedalaahagag ahmedalaahagag marked this pull request as ready for review June 28, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant