fix: CI workflow fails on docs-only PRs#6
Merged
Merged
Conversation
The workflow was on feat/docs which has no pyproject.toml or uv.lock, causing uv sync to fail on that PR. CI belongs with the code it tests. Also pins cache-dependency-glob to uv.lock explicitly so setup-uv does not emit a warning when scanning for lockfiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI workflow was committed in
feat/docs, which contains nopyproject.tomloruv.lock. When GitHub Actions ran on that PR it tried to executeuv sync --all-extrasagainst an empty merge commit and failed immediately.Additionally,
setup-uvwithenable-cache: truebut no explicitcache-dependency-globscanned foruv.lockand emitted a "No matches found" warning.Fix
ci.ymlto this dedicated branch so it reachesmainindependently and cleanlycache-dependency-glob: uv.lockto silence the glob warningMerge order
This should be merged before
feat/docs(#4). Once this is onmain, all subsequent PR merge commits will include both the workflow and the Python source (fromfeat/core-gateway#1), so CI will pass end-to-end.Recommended merge sequence: #1 → #6 (this) → #2 → #3 → #4 → #5