docs(skills): add missing skill stubs, interactive patterns wizard, d…#5111
docs(skills): add missing skill stubs, interactive patterns wizard, d…#5111mangod12 wants to merge 1 commit intoaden-hive:mainfrom
Conversation
…ebugger fix applier, test preview Fixes several workflow cross-compatibility gaps: - Add missing hive-debugger workflow stub (.agent/workflows/hive-debugger.md) - Add missing triage-issue workflow stub (.agent/workflows/triage-issue.md) - Add missing hive-debugger and triage-issue symlinks in .agent/skills/ and .agents/skills/ - Enrich all 6 existing workflow stubs with description and when_to_use metadata - hive.md: slim from ~500 to 151 lines as pure routing document (remove duplicate phase details) - hive-create: add credential pre-check after tool discovery (Step 1A) - hive-create: add rollback/undo guidance between Steps 5 and 6 - hive-patterns: add interactive AskUserQuestion pattern wizard (was passive reference doc) - hive-test: add test preview/cost-estimation step before execution (Phase 2) - hive-debugger: add Stage 6b interactive fix applier with Edit tool + user approval - settings.local.json.example: add 11 missing MCP tool permissions for debugger and test skills
There was a problem hiding this comment.
Pull request overview
This PR updates the Hive skill/workflow documentation and wiring to close cross-environment gaps, adding missing workflow stubs and enhancing several skills with interactive “wizard”-style guidance and richer metadata.
Changes:
- Add missing workflow stubs (notably
hive-debuggerandtriage-issue) and enrich workflow frontmatter (description,when_to_use) across Hive workflows. - Update multiple Hive skills with new interactive steps (patterns selection wizard, debugger fix applier stage, test execution preview, create rollback guidance).
- Expand
.claude/settings.local.json.examplewith additional MCP tool allow-list entries intended to support debugger/test workflows.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| .claude/skills/hive/SKILL.md | Slim down hive meta-skill into a routing/phase reference document. |
| .claude/skills/hive-test/SKILL.md | Add a “test preview” interaction before executing tests. |
| .claude/skills/hive-patterns/SKILL.md | Add an interactive AskUserQuestion-based patterns selection wizard. |
| .claude/skills/hive-debugger/SKILL.md | Add “Stage 6b” interactive fix application flow (Read/Edit + approval). |
| .claude/skills/hive-create/SKILL.md | Add credential pre-check guidance and rollback/undo guidance during graph design. |
| .claude/settings.local.json.example | Add additional MCP tool permissions intended for test/debug flows. |
| .agents/skills/triage-issue | Add skill link entry for triage-issue. |
| .agents/skills/hive-debugger | Add skill link entry for hive-debugger. |
| .agent/workflows/triage-issue.md | Add workflow stub with metadata for triage-issue. |
| .agent/workflows/hive.md | Enrich hive workflow metadata and add quick reference routing. |
| .agent/workflows/hive-test.md | Enrich hive-test workflow metadata. |
| .agent/workflows/hive-patterns.md | Enrich hive-patterns workflow metadata. |
| .agent/workflows/hive-debugger.md | Add workflow stub with metadata for hive-debugger. |
| .agent/workflows/hive-credentials.md | Enrich hive-credentials workflow metadata. |
| .agent/workflows/hive-create.md | Enrich hive-create workflow metadata. |
| .agent/workflows/hive-concepts.md | Enrich hive-concepts workflow metadata. |
| .agent/skills/triage-issue | Add skill link entry for triage-issue. |
| .agent/skills/hive-debugger | Add skill link entry for hive-debugger. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| **Before running tests, preview what will execute:** | ||
|
|
||
| ```python | ||
| # Preview: list tests and estimate cost/time without running them | ||
| list_tests( | ||
| goal_id="your-goal-id", | ||
| agent_path="exports/{agent_name}" | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
The comment implies list_tests can "estimate cost/time". The MCP tool only returns counts/grouping and a run command; any time/cost numbers here would be heuristic derived from the counts. Consider rewording to make it clear that the preview comes from list_tests output and any cost/time is an approximation you compute/present (not returned by the tool).
| > | Success tests | 8 | ~24s | ~$0.08 | | ||
| > | **Total** | **12** | **~36s** | **~$0.12** | | ||
| > | ||
| > Each test makes real LLM calls (~3s + tokens per test). |
There was a problem hiding this comment.
This line states that each test makes real LLM calls. The existing guidance in this skill supports mock_mode / MOCK_MODE=1, and in that mode tests should not incur real LLM/API cost. Suggest clarifying that the cost/time estimate applies to non-mock runs (and may vary per test/tool).
| > Each test makes real LLM calls (~3s + tokens per test). | |
| > In non-mock runs, each test makes real LLM calls (~3s + tokens per test); with `mock_mode` / `MOCK_MODE=1`, tests run without real LLM/API cost and timing/cost estimates may differ by test/tool. |
| 6. **Pre-check credentials** for the discovered tools (silent — only warn if issues found): | ||
|
|
||
| ``` | ||
| check_missing_credentials(agent_path="exports/AGENT_NAME") |
There was a problem hiding this comment.
check_missing_credentials is an MCP tool from the agent-builder server, so this call should use the same mcp__agent-builder__... prefix used elsewhere in this step. Also, the tool loads and validates an exported agent via AgentRunner.load(agent_path), which will fail at this point because only an empty directory has been created (no agent.json yet). To make this pre-check effective, move it to after export_graph (once the agent exists), or change the approach to validate credentials based on the discovered tool list instead of an agent export path.
| check_missing_credentials(agent_path="exports/AGENT_NAME") | |
| mcp__agent-builder__check_missing_credentials(agent_path="exports/AGENT_NAME") |
| "mcp__agent-builder__query_runtime_logs", | ||
| "mcp__agent-builder__query_runtime_log_details", | ||
| "mcp__agent-builder__query_runtime_log_raw", |
There was a problem hiding this comment.
These permissions list query_runtime_logs, query_runtime_log_details, and query_runtime_log_raw under the agent-builder server, but those tools are registered by the separate tools MCP server (see aden_tools.tools.runtime_logs_tool). With the current entries, Claude/agents won't be able to call these tools even if tools is enabled. Update the allow-list entries to the correct server prefix (e.g., mcp__tools__query_runtime_logs, etc.).
| "mcp__agent-builder__query_runtime_logs", | |
| "mcp__agent-builder__query_runtime_log_details", | |
| "mcp__agent-builder__query_runtime_log_raw", | |
| "mcp__tools__query_runtime_logs", | |
| "mcp__tools__query_runtime_log_details", | |
| "mcp__tools__query_runtime_log_raw", |
| @@ -0,0 +1 @@ | |||
| ../../.claude/skills/hive-debugger No newline at end of file | |||
There was a problem hiding this comment.
This file appears to be checked in as a regular text file containing a relative path, not as a symlink to the skill directory. Other entries under .agents/skills/ resolve as directories (symlinks) with a SKILL.md; this one does not, so the skill loader likely won't find the debugger skill. Commit this as an actual symlink (git mode 120000) pointing to ../../.claude/skills/hive-debugger (matching the existing skill link convention).
| ../../.claude/skills/hive-debugger | |
| // (intentionally left empty; this file should be replaced by a git symlink | |
| // pointing to ../../.claude/skills/hive-debugger) |
| @@ -0,0 +1 @@ | |||
| ../../.claude/skills/triage-issue No newline at end of file | |||
There was a problem hiding this comment.
This file appears to be checked in as a regular text file containing a relative path, not as a symlink to the skill directory. Other entries under .agents/skills/ resolve as directories (symlinks) with a SKILL.md; this one does not, so the triage-issue skill likely won't be discoverable. Commit this as an actual symlink (git mode 120000) pointing to ../../.claude/skills/triage-issue.
| ../../.claude/skills/triage-issue |
| @@ -0,0 +1 @@ | |||
| ../../.claude/skills/hive-debugger No newline at end of file | |||
There was a problem hiding this comment.
This file appears to be checked in as a regular text file containing a relative path, not as a symlink to the skill directory. In this repo, .agent/skills/<skill> entries resolve as directories with a SKILL.md; this one does not, so the workflow stub may not be able to load the hive-debugger skill. Commit this as an actual symlink (git mode 120000) pointing to ../../.claude/skills/hive-debugger.
| @@ -0,0 +1 @@ | |||
| ../../.claude/skills/triage-issue No newline at end of file | |||
There was a problem hiding this comment.
This file appears to be checked in as a regular text file containing a relative path, not as a symlink to the skill directory. In this repo, .agent/skills/<skill> entries resolve as directories with a SKILL.md; this one does not, so the triage-issue workflow likely won't be able to load the skill. Commit this as an actual symlink (git mode 120000) pointing to ../../.claude/skills/triage-issue.
| **To remove a node:** Call `mcp__agent-builder__remove_node(node_id="node-to-remove")` and remove its corresponding edges. | ||
|
|
||
| **To modify a node:** Re-call `mcp__agent-builder__add_node(...)` with the same `node_id` — it overwrites the existing definition. | ||
|
|
||
| **To remove an edge:** Call `mcp__agent-builder__remove_edge(edge_id="edge-to-remove")`. |
There was a problem hiding this comment.
The rollback instructions reference mcp__agent-builder__remove_node / remove_edge, but the agent-builder MCP server exposes these as delete_node and delete_edge (and delete_node already removes connected edges). Using the current names will fail at runtime; please update the tool names and guidance accordingly.
| **To remove a node:** Call `mcp__agent-builder__remove_node(node_id="node-to-remove")` and remove its corresponding edges. | |
| **To modify a node:** Re-call `mcp__agent-builder__add_node(...)` with the same `node_id` — it overwrites the existing definition. | |
| **To remove an edge:** Call `mcp__agent-builder__remove_edge(edge_id="edge-to-remove")`. | |
| **To remove a node:** Call `mcp__agent-builder__delete_node(node_id="node-to-remove")` (this will also remove any connected edges). | |
| **To modify a node:** Re-call `mcp__agent-builder__add_node(...)` with the same `node_id` — it overwrites the existing definition. | |
| **To remove an edge:** Call `mcp__agent-builder__delete_edge(edge_id="edge-to-remove")`. |
| "mcp__agent-builder__remove_node", | ||
| "mcp__agent-builder__remove_edge" |
There was a problem hiding this comment.
mcp__agent-builder__remove_node / mcp__agent-builder__remove_edge are not tools exposed by the agent-builder MCP server (the available tools are delete_node / delete_edge). As written, these permission entries won't match any callable tool name; update to the correct tool names.
| "mcp__agent-builder__remove_node", | |
| "mcp__agent-builder__remove_edge" | |
| "mcp__agent-builder__delete_node", | |
| "mcp__agent-builder__delete_edge" |
…ebugger fix applier, test preview
Fixes several workflow cross-compatibility gaps:
Description
Brief description of the changes in this PR.
Type of Change
Related Issues
Fixes #(issue number)
Changes Made
Testing
Describe the tests you ran to verify your changes:
cd core && pytest tests/)cd core && ruff check .)Checklist
Screenshots (if applicable)
Add screenshots to demonstrate UI changes.