fix(runner): replace print statements with logger.warning [micro-fix]#3441
Open
Akshat050 wants to merge 2 commits intoadenhq:mainfrom
Open
fix(runner): replace print statements with logger.warning [micro-fix]#3441Akshat050 wants to merge 2 commits intoadenhq:mainfrom
Akshat050 wants to merge 2 commits intoadenhq:mainfrom
Conversation
added 2 commits
February 3, 2026 13:37
Use the existing logger instead of print() for warning messages in AgentRunner._setup(). This ensures consistent logging behavior and allows warning messages to be properly configured via the logging system. Changes: - Replace 4 print() calls with logger.warning() in runner.py - Logger was already configured but not used for these warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
print()statements withlogger.warning()inAgentRunner._setup()for consistent logging behavior.Problem
The file
core/framework/runner/runner.pyhas a logger configured on line 27:And uses it correctly in some places (lines 430, 432), but uses
print()for warnings in other places (lines 480-493). This is inconsistent.Changes
Replace 4
print()calls withlogger.warning():Why