test: trying to reduce timeout in order to get a better error message…

… and swapping to an earlier ubuntu runner
aditosoftware · Feb 10, 2025 · 16ae953 · 16ae953
1 parent 5c3db40
commit 16ae953
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -12,8 +12,8 @@ jobs:
         # Therefore, we can not install and start a docker container in the WSL.
 
         # Currently, no macOS runner, because during the setup of docker, this runner hangs: https://github.com/douglascamata/setup-docker-macos-action/issues/37
-        os: [ubuntu-latest]
-        node-version: [18.x, 20.x, 22.x]
+        os: [ubuntu-22.04]
+        node-version: [20.x, 22.x]
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
@@ -65,8 +65,8 @@ jobs:
         # Therefore, we can not install and start a docker container in the WSL.
 
         # Currently, no macOS runner, because during the setup of docker, this runner hangs: https://github.com/douglascamata/setup-docker-macos-action/issues/37
-        node-version: [18.x, 20.x, 22.x]
-        os: [ubuntu-latest]
+        node-version: [20.x, 22.x]
+        os: [ubuntu-22.04]
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
@@ -136,7 +136,7 @@ jobs:
         run: npm run lint -- --format json --output-file eslint-results.json || true
 
       - name: Analyze with SonarCloud
-        uses: SonarSource/sonarcloud-github-action@master
+        uses: SonarSource/sonarqube-scan-action@v4
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         with:

diff --git a/src/test/e2e/webview/WebviewTestUtils.ts b/src/test/e2e/webview/WebviewTestUtils.ts
@@ -50,7 +50,7 @@ export class WebviewTestUtils {
           return false;
         }
       },
-      10_000,
+      2_000,
       "waiting for the webview to open"
     );
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -50,7 +50,7 @@ export class WebviewTestUtils { @@
               return false;
             }
           },
-_000,
+_000,
           "waiting for the webview to open"
         );
       }
@@ Expand Down @@