Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improved e2e tests in order to work in ubuntu-latest pipeline again (#2048869) #48

Merged
merged 12 commits into from
Feb 11, 2025

Conversation

rH4rtinger
Copy link
Collaborator

@rH4rtinger rH4rtinger commented Feb 10, 2025

Please check before merging

  • Is the content of the README.md file still up-to-date?
  • Have you added an entry to the CHANGELOG.md?
  • Is the pull request title written in the Conventional Commits format?
  • VSCode: Did you write e2e tests?
  • VSCode: Did you follow the UX Guidelines?

Description

fixed github pipeline in order to execute e2e tests again:

  • replaced VSBrowser.instance.openResources with other (native) VSCode options, because it does no longer work on ubuntu-24, see [🚫 Bug] openResources() not working on Ubuntu 24.04 redhat-developer/vscode-extension-tester#1701
  • removed node 18 in the node versions, because it is quite an old version
  • changed sonar action to the non deprecated action
  • moved some tests classes, in order to execute the webview tests before the command tests. It was the other way around before my change, and the pipeline no longer worked. Swapping those was a logical thing, because in the command tests there is also the webview needed to create the config. If the config tests are not working, the other tests might also not work
  • only opened the workspace once per all tests
  • adding some force in order to remove some folders during the tests

@rH4rtinger rH4rtinger changed the title test: checking pipeline ci: improved e2e tests in order to work in ubuntu-latest pipeline again (#2048869) Feb 11, 2025
@rH4rtinger rH4rtinger requested a review from Fabustus February 11, 2025 07:42
@rH4rtinger rH4rtinger marked this pull request as ready for review February 11, 2025 07:42
@rH4rtinger rH4rtinger requested a review from a team as a code owner February 11, 2025 07:42
@rH4rtinger rH4rtinger merged commit 7e47a30 into main Feb 11, 2025
7 checks passed
@rH4rtinger rH4rtinger deleted the pipeline-tests branch February 11, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants