Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts the UDP multicast support that was added in PR #79. The revert cleanly removes all multicast-related functionality including the multicast socket class, helper functions, test infrastructure, and build system configuration.
Changes:
- Removed entire multicast test file and related test infrastructure
- Removed multicast API classes and methods from socket header
- Removed platform-specific multicast implementations from UDP socket implementations
- Removed build configuration options for multicast support
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/src/test_async_io_multicast.cpp | Complete removal of multicast test suite (189 lines) |
| tests/CMakeLists.txt | Removed WEBCRAFT_HAS_MULTICAST compile definitions |
| src/webcraft/async_udp.cpp | Removed multicast join/leave implementations across all platforms (Windows IOCP, Linux io_uring, macOS kqueue) and removed netinet/in.h includes |
| include/webcraft/async/io/socket.hpp | Removed multicast_group, multicast_join_options, multicast_socket class, and helper function is_multicast_address |
| CMakeLists.txt | Removed WEBCRAFT_HAS_MULTICAST build option |
| .github/workflows/build.yml | Removed -DWEBCRAFT_HAS_MULTICAST=OFF flag from macOS build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #79