MOB-24285 - Ensure the message requesting a fullscreen dismiss is the same message currently being shown #1192
+97
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icter handling of dismissal code
…ailable for extensions
praveek
reviewed
Nov 18, 2025
| /// If no message is passed in, the code will pass and try to dismiss any message that was otherwise showing. | ||
| /// - Parameter message: `Showable` of message to dismiss | ||
| /// - Returns: `true` if a message was dismissed | ||
| func dismiss(_ message: Showable?) -> Bool |
Contributor
There was a problem hiding this comment.
Remove the leading underscore from the parameter name in the dismiss function, as it may cause a conflict with the function above.
… the protocol definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.corp.adobe.com/browse/MOB-24285
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: