GH-230 removing unwanted/unneeded/unused cloudevent serializer and deserializer and hence dependency #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serializer and hence dependency
francoisledroff
temporarily deployed
to
aio_prod
GitHub Actions
Inactive
francoisledroff
temporarily deployed
to
aio_stage_oauth
GitHub Actions
Inactive
francoisledroff
temporarily deployed
to
aio_stage
GitHub Actions
Inactive
9 tasks
Comment on lines
-38
to
-40
| .addModule(new SimpleModule() | ||
| .addSerializer(ZonedDateTime.class, new ZonedDateTimeSerializer()) | ||
| .addDeserializer(ZonedDateTime.class, new ZonedDateTimeDeserializer())) |
Member
There was a problem hiding this comment.
How do we make sure that it won't fail in serialization/deserialization? Does Jackson support these date formats OOTB?
Collaborator
Author
There was a problem hiding this comment.
what matters here is the objectmapper pulled from here is properly serializating/deserializing dates/times when used with the models stuffed in our sdk, right ?
and I believe it's the case :
the only 2 dates found in our json model are actually currently exposed as String in the Registration class : they were no need for this in the first place ...
Collaborator
Author
There was a problem hiding this comment.
AFAIK the only place where we used Date type in our jackson powered model are in the aem module when serializing aem event
francoisledroff
temporarily deployed
to
aio_stage
GitHub Actions
Inactive
francoisledroff
had a problem deploying
to
aio_stage_oauth
GitHub Actions
Error
francoisledroff
temporarily deployed
to
aio_prod
GitHub Actions
Inactive
shikhartanwar
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
GH-230
Motivation and Context
removing unwanted/unneeded/unused cloudevent serializer and deserializer and hence dependency
It was introduced here Add support for Registration V2 API #126
@JsonFormatwe still have this
events_ingress: replace ourCloudEventmodel by the Open sourcecloudevents/sdk-javamodel . #16 pendingbut for now I propose we remove this annoying dependency
Types of changes
Checklist: