support multi-lang sitemaps #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…i-language support
| return sitemapDef | ||
| && typeof sitemapDef.languages === 'object' | ||
| && sitemapDef.languages !== null | ||
| && Object.keys(sitemapDef.languages).length > 0; |
There was a problem hiding this comment.
This works fine if there's already a multi-lang sitemap set up already and you need to edit it and add a new language, but it doesn't let you create a new one from scratch and always shows the default sitemap-details-dialog-template because it expects at least one language to exist. I think just sitemapDef?.languages should work.
| </div> | ||
| </li> | ||
| </template> | ||
| <template id="sitemap-multilang-dialog-template"> |
There was a problem hiding this comment.
Not required but might be worth adding a back button in each of these templates so the user doesn't have to exit out of the modal and hit "add new" again to start over?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs: