Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React RUM] media observers #212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

igor-grubic
Copy link

The current implementation only captures media mutations in a data-block.
This implementation adds a generic media observer for React containers.

Notes:

  • This was a bit rushed and lacks more thought, however it could be useful for discussion purposes.
  • When trying to solve the question of "when is react finished loading" i have not found a generic solution that does not require some kind of implementation on the react side, hence the observers on the react container
  • I think that the proposed solution, depending on the size of the react app, can have performance impacts on the host app and should be tested a bit more in depth.
  • another idea could involve using setTimeouts (or something in a polling method) instead, which would be less precise but less impactful performance wise
  • Is the current implementation of data-block only going to change? If so, we might want to have a generic solution that solves both problems.

@igor-grubic igor-grubic changed the title Issue/rrum viewmedia [React RUM] media observers Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant