fix(s3): report last-modified diff after saving #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominique-pfister
changed the title
tripodsan
approved these changes
Jul 12, 2024
adobe-bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
# [@adobe/helix-shared-tokencache-v1.4.20](https://github.com/adobe/helix-shared/compare/@adobe/helix-shared-tokencache-v1.4.19...@adobe/helix-shared-tokencache-v1.4.20) (2024-07-12) ### Bug Fixes * **s3:** report last-modified diff before saving ([#970](#970)) ([fe2939c](fe2939c))
|
🎉 This PR is included in version @adobe/helix-shared-tokencache-v1.4.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #969
as a first step, just log the diff when saving to get an estimation how often S3 token cache gets written back