Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to yarn patches #6772

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Move to yarn patches #6772

wants to merge 18 commits into from

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Jul 26, 2024

Closes

ALERT: This PR is incompatible with Lerna, we'll need to move manual releases over to yarn instead. @devongovett

Move us off of patch-package and use yarn's native support for patching https://yarnpkg.com/cli/patch

Of note, yarn patching syntax is incompatible with lerna, at least at the version we have. So I've taken the liberty of moving the CI stuff using lerna over to the yarn versioning.
This will still be an issue for a real manual release until we can move to yarn for that as well.

Need to consult with @LFDanLu why verdaccio isn't running locally for me anymore. Haven't been able to decipher it yet.
UPDATE: Verdaccio issue seems to be some sort of a cache issue, as long as there is only one verdaccio server possible, everyone should be fine. Hopefully this is an issue with Yarn and will be updated in the future
Will need something like yarnpkg/berry#6420 to debug further. Again, everyone should be fine as verdaccio is seldom needed locally and we only use verdaccio.sh. I've removed the competing one, test-prod.sh, which had a different port.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jul 26, 2024

@rspbot
Copy link

rspbot commented Jul 26, 2024

@adobe adobe deleted a comment from rspbot Jul 29, 2024
@adobe adobe deleted a comment from rspbot Jul 29, 2024
@rspbot
Copy link

rspbot commented Jul 29, 2024

1 similar comment
@rspbot
Copy link

rspbot commented Jul 29, 2024

# Conflicts:
#	.yarn/patches/recast+0.23.6.patch
#	.yarn/patches/storybook-builder-parcel-https-7ea26540e8.patch
#	package.json
#	yarn.lock
@snowystinger snowystinger changed the title [WIP] - Move to yarn patches Move to yarn patches Jul 30, 2024
@rspbot
Copy link

rspbot commented Jul 30, 2024

1 similar comment
@rspbot
Copy link

rspbot commented Jul 30, 2024

@rspbot
Copy link

rspbot commented Jul 30, 2024

@rspbot
Copy link

rspbot commented Jul 30, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@rspbot
Copy link

rspbot commented Jul 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants