-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to yarn patches #6772
base: main
Are you sure you want to change the base?
Move to yarn patches #6772
Conversation
This reverts commit 6d9aadc.
8552c3f
to
03beadd
Compare
1 similar comment
# Conflicts: # .yarn/patches/recast+0.23.6.patch # .yarn/patches/storybook-builder-parcel-https-7ea26540e8.patch # package.json # yarn.lock
1 similar comment
## API Changes
unknown top level export { type: 'any' } |
Closes
ALERT: This PR is incompatible with Lerna, we'll need to move manual releases over to yarn instead. @devongovett
Move us off of patch-package and use yarn's native support for patching https://yarnpkg.com/cli/patch
Of note, yarn patching syntax is incompatible with lerna, at least at the version we have. So I've taken the liberty of moving the CI stuff using lerna over to the yarn versioning.
This will still be an issue for a real manual release until we can move to yarn for that as well.
Need to consult with @LFDanLu why verdaccio isn't running locally for me anymore. Haven't been able to decipher it yet.
UPDATE: Verdaccio issue seems to be some sort of a cache issue, as long as there is only one verdaccio server possible, everyone should be fine. Hopefully this is an issue with Yarn and will be updated in the future
Will need something like yarnpkg/berry#6420 to debug further. Again, everyone should be fine as verdaccio is seldom needed locally and we only use verdaccio.sh. I've removed the competing one, test-prod.sh, which had a different port.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: