add all S2 components to example apps #7027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…react-spectrum into s2-example-app-components
1 similar comment
1 similar comment
|
hover text color on menu item link seems wrong? |
|
@devongovett I'm not seeing that anywhere. Which browser? |
|
Safari Mac |
|
Interesting, not seeing that on Safari 17.6 Intel. |
|
hmm ok doesn't happen in the safari tech preview |
This reverts commit 3be5f9c.
1 similar comment
|
Not sure why there isn't a comment on my commit, but here's the s2 parcel link |
snowystinger
approved these changes
Sep 26, 2024
devongovett
approved these changes
Sep 26, 2024
|
We should add some of the new components like Accordion, CardView, Table, SegmentedControl, etc. in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all S2 components to Parcel and Webpack example apps for testing purposes.
We'll need to investigate TagGroup crashing in a follow-up.
✅ Pull Request Checklist:
📝 Test Instructions:
Check Parcel example and Webpack example
🧢 Your Project: