Skip to content

fix: preserve aria labels for cell and column of table #8515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ctith-workfront
Copy link

@ctith-workfront ctith-workfront commented Jul 9, 2025

Preserve aria label prop passed into Cell and Column

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Cell and Column components of Table should apply aria label attributes in the DOM.

image

@yihuiliao
Copy link
Member

yihuiliao commented Jul 28, 2025

Hi, thanks for the PR! Mind giving some context for this? Screenreader's should be reading out the content inside the cell/column even without an attached aria-label

Also you'll need to sign the CLA for all the checks to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants