Skip to content

fix: Swiss currency parsing #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 6, 2025
Merged

fix: Swiss currency parsing #8546

merged 5 commits into from
Aug 6, 2025
+12 −0

Conversation

snowystinger
Copy link
Member

Closes #8545

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger mentioned this pull request Jul 15, 2025
Closed
@rspbot
Copy link

rspbot commented Jul 15, 2025

Build successful! 🎉

reidbarber
reidbarber previously approved these changes Jul 15, 2025
View reviewed changes
snowystinger
snowystinger commented Jul 17, 2025
View reviewed changes
@rspbot
Copy link

rspbot commented Jul 17, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jul 26, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jul 26, 2025

Build successful! 🎉

@devongovett devongovett added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 22e397e Aug 6, 2025
32 checks passed
@devongovett devongovett deleted the fix-swiss-currency branch August 6, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@reidbarber reidbarber reidbarber left review comments

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NumberParser: Does not parse numbers with apostrophes as thousand seperator
5 participants
@snowystinger @rspbot @devongovett @reidbarber @LFDanLu