Skip to content

Conversation

tkotthakota-adobe
Copy link
Contributor

@tkotthakota-adobe tkotthakota-adobe commented Oct 1, 2025

https://jira.corp.adobe.com/browse/SITES-35658

Tests

  1. Form is updated with Scheduled Run option
image
  1. When demo profile is selected by default schedule run is false. No Schedule run option selected from form to overwrite what is on profile. Notice we continue disabling possible imports and audits after onboard site run.
image
  1. When Schedule Run from form is selected to true to overwrite what is on profile.
image image
  1. When paid profile is given in command line, scheduled run is set to true and disable of imports and audits shall be skipped.
image
  1. When paid profile is given in command line scheduleRun is set to true in the profile. However it can be overwritten in the onboard run form. When false selected for scheduled run on the form, it is honored - imports and audits are disabled as applicable.
image

Copy link

github-actions bot commented Oct 2, 2025

This PR will trigger no release when merged.

{
text: {
type: 'plain_text',
text: 'Default',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should do the free trial as a default. We have less paid customers than demo/free trial.
Also, as an idea. Do we want to split Free Trial vs demo preparation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo is treated as Default. So Default is not used any more.
Paid/FreeTrail is in one category.

},
"integrations": {}
},
"summit": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove summit at all ?(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I asked this question in our engg channel. Summit, Default can be removed.

Copy link

@irenelagno irenelagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it business requirement to do paid default? I would use free as default

@tkotthakota-adobe
Copy link
Contributor Author

Is it business requirement to do paid default? I would use free as default

No Demo is used as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants