feat: add query for fetching RUM engagement metrics #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
dipratap
changed the title
packages/spacecat-shared-rum-api-client/src/functions/user-engagement.js
Show resolved
Hide resolved
| function handler(bundles) { | ||
| const urlsData = {}; | ||
| bundles.forEach((bundle) => { | ||
| const engagementTraffic = hasEngagement(bundle) ? bundle.weight : 0; |
There was a problem hiding this comment.
The ternary operator isn’t needed here, as hasEngagement() already returns either bundle.weight or 0.
packages/spacecat-shared-rum-api-client/src/functions/user-engagement.js
Show resolved
Hide resolved
prithipalpatwal
approved these changes
Oct 7, 2025
solaris007
pushed a commit
that referenced
this pull request
Oct 7, 2025
# [@adobe/spacecat-shared-data-access-v2.68.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v2.67.0...@adobe/spacecat-shared-data-access-v2.68.0) (2025-10-07) ### Features * add query for fetching RUM engagement metrics ([#985](#985)) ([0eb8881](0eb8881))
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.68.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
solaris007
pushed a commit
that referenced
this pull request
Oct 7, 2025
# [@adobe/spacecat-shared-rum-api-client-v2.38.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.37.8...@adobe/spacecat-shared-rum-api-client-v2.38.0) (2025-10-07) ### Features * add query for fetching RUM engagement metrics ([#985](#985)) ([0eb8881](0eb8881))
|
🎉 This PR is included in version @adobe/spacecat-shared-rum-api-client-v2.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new query in rum api client for fetching user-engagement metrics from RUM.