Repository navigation
fix(design-data): pin structure-prefixed legacy keys and add regression test - #1544
Merged
GarthDB merged 3 commits intoOct 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 6d08bae The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
Run report for 6d08baeaTotal time: 3m 40s | Comparison time: 8m 43s | Estimated savings: 5m 2s (57.8% faster)
Expanded report
Changed files |
GarthDB
added this pull request to stack #1545
October 15, 2026 21:47
GarthDB
force-pushed
the
fix/mra7-structure-legacy-keys
branch
from
October 15, 2026 21:48
b27679c to
f034a5e
Compare
GarthDB
force-pushed
the
fix/mra7-structure-legacy-keys
branch
from
October 15, 2026 22:14
f034a5e to
2c820b6
Compare
…on test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GarthDB
force-pushed
the
fix/mra7-structure-legacy-keys
branch
from
October 15, 2026 22:18
2c820b6 to
6d08bae
Compare
Merged
GarthDB
pushed a commit
that referenced
this pull request
Oct 15, 2026
…on test (#1544) - Add `name.legacyKey` pins for five structure-prefixed layout tokens so they survive the legacy round trip. - Add a regression test over the canonical corpus that fails if the corpus is missing. - Add changesets for the data and WASM packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack 3/3 (based on #1543). Follow-up to #1517 (mra7):
name.legacyKeypins to the five live records (banner-gap-horizontal,banner-gap-vertical,banner-padding-horizontal,banner-padding-vertical,list-gap-regular) so the names no longer depend on thestructurefield flag.structure_prefixed_legacy_keys_survive_convert_graph:legacy::convert_graphkeeps the five original UUIDs and values on the live keys, and the old unprefixed keys stay distinct deprecated compat records with the same values.Generated legacy output is unchanged.
Related Issue
Bead
spectrum-design-data-mra7; follows #1517.Motivation and Context
Review notes on #1517 asked for explicit pins and regression coverage of UUID identity.
How Has This Been Tested?
moon run sdk:codegen,moon run sdk:codegen-check: passed.moon run design-data:validate: passed.moon run design-data:legacy-output: passed, no diff.moon run sdk:test: passed (1562 tests).moon run sdk:lint,moon run sdk:fmt: passed.moon run root:check-legacy-consumers: passed.node tools/changeset-linter/src/cli.js check --fail-on-warnings: passed.Screenshots (if appropriate):
N/A
Types of changes
Checklist: