feat(feedback): store bash command in feedback ledger metadata#133
Closed
leshchenko1979 wants to merge 2 commits into
Closed
feat(feedback): store bash command in feedback ledger metadata#133leshchenko1979 wants to merge 2 commits into
leshchenko1979 wants to merge 2 commits into
Conversation
5b7d015 to
126b6fa
Compare
The new feedback snippet code references tool_input.get("command") after
tool_input is moved into execute(). Adding .clone() at both execute()
call sites resolves the borrow checker error.
Owner
|
Thanks for the PR! I already shipped this fix in The approach is the same idea — append the bash command to the feedback ledger meta so RSI / SQL can group failures by subsystem — with a few extras:
Same outcome for RSI either way. Really appreciate you taking the time to write this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When bash commands fail, the feedback ledger records the error output but not the actual command that was run. RSI currently sees
Command exited with code 1but can't tell whether it was a git operation, python script, docker command, or something else — all bash failures are lumped into one bucket.Change
In
tool_loop.rs, bothrecord_tool_feedbackcall sites now prepend the command text to the error snippet for bash failures:Command exited with code 1[command: git pull origin main] Command exited with code 1(+ stdout/stderr)The command is truncated to 300 chars (metadata is limited to 500). Non-bash tools and successful calls are unchanged.
Why
RSI analyzes per-tool failure rates. With the command in metadata, it can now group bash failures by command type (git, python, pip, docker, ssh) and surface targeted improvement opportunities for the actual failing subsystem — not just generic "bash has >20% failure rate" noise.