Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation in Hamburger not scrolling #7

Open
Geeksta opened this issue May 21, 2014 · 6 comments · May be fixed by #16
Open

Navigation in Hamburger not scrolling #7

Geeksta opened this issue May 21, 2014 · 6 comments · May be fixed by #16

Comments

@Geeksta
Copy link

Geeksta commented May 21, 2014

We have a rather lengthy navigation but it won't scroll on devices.

@arielsalminen
Copy link
Contributor

Yeah, this is currently a limitation of this solution. I’ll try to come up with a good way scroll it though soon, since it seems we need it too in one of our project!

MystK added a commit to MystK/fixed-nav that referenced this issue May 14, 2015
Fixes [adtile#7](adtile#7). It works with long lists now.
@MystK MystK linked a pull request May 14, 2015 that will close this issue
@voodoo6
Copy link

voodoo6 commented May 28, 2015

Hi MystK,

I've been waiting for a fix for this for ages! (the javascript is beyond my skills I'm afraid).

I tried your solution but it seems to have issues when testing on my iPhone – once the menu has been opened, the nav is no longer fixed and remains where it was opened on the page. Also, once the menu is opened, the header bar becomes scrollable, it would make sense it it could be fixed in place the whole time?

Difficult to describe all in all! – I've put your commit here, the only thing I've done is add more nav items to create a long nav: http://voodoo6.com/fixed-nav-mystk/

Try it on a mobile to see what I mean.. do you see the same issues when testing?

@lipsync
Copy link

lipsync commented May 28, 2015

I tested the fix on Android, but nothing changed - still can't scroll larger menus.

@pgarciacamou
Copy link
Contributor

Hi MystK,

I tested on iOS 6.0 w/safari and it brakes the nav-bar's position.

@breakfastpizza
Copy link

Hi all, has there been any progress on fixing this functionality? I'm using this plugin on a site with a VERY long menu which gets cut off in mobile and I would like to be able to scroll through.

@dmegatool
Copy link

I think this can be done with css alone. If you put a max-height on the UL based on the screen size (let say calc(100vh - 50px)... or whatever fits your design) and set the overflow to auto or scroll, it should work as LI flow out of the UL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants