Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navigation close on scroll #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MystK
Copy link

@MystK MystK commented May 13, 2015

Navigation should automatically close on scroll.

This was tested working with the latest Microsoft Edge, Firefox, Chrome, and iOS.

Navigation should automatically close on scroll. This was tested working with the latest Microsoft Edge, Firefox, Chrome, and iOS.
@MystK
Copy link
Author

MystK commented May 13, 2015

It's probably better to add another event listener to be more in line with the current coding style. A disadvantage would be more memory usage. What do you guys think?

@pgarciacamou
Copy link
Contributor

Hi MystK,

I agree on what you are saying, but this would have a direct impact on issue #7, if scrolling closes the nav-bar then it will prevent from traversing lengthly lists.

I can think on 2 ways to fix this:

  1. Detecting the origin of the touch when the user started and if it is outside the nav, then close it.
  2. When lengthly lists, if the nav-bar is larger than the screen, do not close it when scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants