Remove extension /thinking command that conflicts with pi 0.85.1 built-in - #274
Open
NgThachThanh wants to merge 1 commit into
Open
Remove extension /thinking command that conflicts with pi 0.85.1 built-in#274NgThachThanh wants to merge 1 commit into
NgThachThanh wants to merge 1 commit into
Conversation
…t-in pi 0.85.1 added a built-in interactive /thinking command, so the extension-registered one collides and pi skips it with a startup warning. Drop the extension command in favor of the built-in one: delete registerThinkingCommand, its test, and the doc rows that advertised it.
|
@NgThachThanh is attempting to deploy a commit to the Advait Paliwal's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273
What
pi
0.85.1added a built-in interactive/thinkingcommand. Feynman's ownregisterThinkingCommand(added per #196) now collides with it, and pi prints this on every session start:This PR drops the extension command in favor of the built-in one.
Changes
extensions/research-tools.ts— remove theregisterThinkingCommandimport and registration callextensions/research-tools/thinking.ts— delete (command implementation)tests/thinking-command.test.ts— delete (test for the removed command)README.md,website/src/content/docs/reference/slash-commands.md— remove the/thinkingrow from the workflow/slash-command tableswebsite/src/content/docs/reference/package-stack.md— remove/thinkingfrom the Feynman command listRELEASES.md,CHANGELOG.md,website/.../releases.md) left untouchedChecks
npm run typecheck— ✅ exit 0npm test— same result as cleanupstream/main: 9 failures, all pre-existing environmental (workbench artifact/env tests, deterministic-ZIP mtime test). Verified identical failure list on clean main before and after the change, so this PR introduces no new failures.npm run build— ✅ exit 0Environment
pi 0.85.1, Node 24.20.0 (per
.nvmrc), Linux (WSL2)