Skip to content

Begin dataflow lib upgrade generic portions #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 20, 2025

Conversation

knewbury01
Copy link
Contributor

@knewbury01 knewbury01 commented Aug 15, 2025

What This PR Contributes

this PR adds a portion of the needed dataflow upgrade to address the dataflow deprecation

the queries affected by this PR are:

  • javascript/frameworks/cap/src/cqlinjection/CqlInjection.ql
  • javascript/frameworks/cap/src/sensitive-exposure/SensitiveExposure.ql
  • javascript/frameworks/cap/src/loginjection/LogInjection.ql
  • javascript/frameworks/xsjs/src/XSJSSqlInjection/XSJSSqlInjection.ql
  • javascript/frameworks/xsjs/src/XSJSUrlRedirect/XSJSUrlRedirect.ql
  • javascript/frameworks/xsjs/src/XSJSReflectedXss/XSJSReflectedXss.ql

Future Works

anything related to the UI5 path graph is covered in this PR, separately from this one

from the XSJS queries:
javascript/frameworks/xsjs/src/XSJSZipSlip/XSJSZipSlip.ql still needs translation, it follows a less direct sanitizer implementation pattern and will require more attention to understand the equivalent concept

@knewbury01 knewbury01 self-assigned this Aug 15, 2025
@knewbury01 knewbury01 marked this pull request as ready for review August 18, 2025 20:26
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeongsoolee09 jeongsoolee09 merged commit 56866cb into main Aug 20, 2025
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the knewbury01/dataflow-lib-upgrade-simple branch August 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants