Address FN involving CAP remote flow sources #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
This PR fixes false negative cases where the current CAP remote flow source definition
UserProvidedPropertyReadOfHandlerParameterOfExposedService
is missing detections from the code that comes in the following form:Two things are notable in the above case:
Unfortunately, the CodeQL Standard Library for JavaScript cannot detect the above
(srv) => { srv.on(...) }
element due to some limitations (see issue #221). Therefore, we directly describe the above patternmodule.exports = (...) => { ... }
as a hack around it.Other than that, the code changes include:
ExportedClosureApplicationServiceDefinition
of aUserDefinedApplicationService
that is defined in the form of an exported function whose first parameter represents the service instance.ServiceInstanceFromExportedClosureParameter
that matches above class.UserDefinedApplicationService.isExposed/0
where a simple negation also captured cases where CDS declarations were missing.HandlerParameterOfExposedService
where the trailing.getCdsDeclaration()
was missing.Future Works
Remove the "hack around it" once the relevant portion of the library is patched and released.