Skip to content

Add default paths to ignore for various languages in build matrix#41

Merged
aegilops merged 1 commit into
mainfrom
paths-ignore
May 9, 2025
Merged

Add default paths to ignore for various languages in build matrix#41
aegilops merged 1 commit into
mainfrom
paths-ignore

Conversation

@felickz

@felickz felickz commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

When applying a paths filter (as is done by this action), the paths-ignore defaults from the CodeQL extractors are NOT utilized. This will likely lead to unwanted detections and decreased performance. This PR aims to pull in some opinionated defaults to continue the journey for improved monorepo scanning.

Primary motivation for this PR was discovered during a performance evaluation

 [2025-04-11 14:37:52] [build-stdout] Done extracting /home/runner/work/sample-javascript-monorepo/sample-javascript-monorepo/packages/babel-cli/src/babel/sample.min.js (3 ms)

Changes to build-matrix.js (used by the changes and whole-repo action):

  • Enhancements to default path ignore patterns:
    • changes/build-matrix.js: Added default path ignore patterns for JavaScript/TypeScript, Java/Kotlin, Python, C#, Ruby, and C/C++ to improve the handling of unnecessary files during scans.
  • Application of default path ignore patterns:
    • changes/build-matrix.js: Implemented logic to apply default path ignore patterns if not explicitly provided in the project configuration. A warning is issued for languages with build-mode: none if no path ignore patterns are set.

Documentation update:

  • README.md: Updated the documentation to reflect the use of default path ignore patterns if not passed in the config input.

@felickz felickz marked this pull request as ready for review April 15, 2025 02:48
@felickz felickz requested a review from a team as a code owner April 15, 2025 02:48
@felickz felickz requested a review from aegilops April 15, 2025 02:48
Comment thread changes/build-matrix.js
felickz

This comment was marked as duplicate.

Comment thread changes/build-matrix.js
Comment thread changes/build-matrix.js
@aegilops aegilops merged commit a834a0a into main May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants