host_url option to CLI and Databricks validator#11
Merged
Conversation
…lidators - Move --host-url from global CLI group to subcommand-level option on validate, check-file, and check-github commands - Add _create_validator() helper using inspect.signature() to only pass kwargs that a validator's __init__ actually accepts, preventing breakage for validators that don't need host_url - Revert host_url from base Checker class - validators that need it (e.g. DatabricksTokenChecker) handle it in their own __init__ - Fix README code fence (4 backticks -> 3) and update example to reflect --host-url as subcommand option - Fix f-string in LOG.error to use %s style for consistency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
@sean-sinclair Thanks for the contribution! Great work! 🎉 I (finally) looked at this! Made small adjustments to actually make the new There are current validators that don't implement it and hardcode the hostname (say google API), but also ones that don't really need any hostname as they don't call anything really (example). Keeping it optional and as sub-command option gives us the flexibility we need. 😄 |
theztefan
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for validating Databricks Personal Access Tokens, including a new validator, CLI integration, documentation, and comprehensive tests. The main changes are grouped below.
Databricks Token Validation Support:
DatabricksTokenCheckerclass invalidators/databricks_token.py, which validates Databricks Personal Access Tokens against a specified workspace URL, supporting both CLI flag and environment variable configuration for the host URL.cli.py) to accept a new--host-urloption, passing it through to validators and ensuring the host URL is available in all relevant commands (check_file,check_github,validate). [1] [2] [3] [4] [5]Checkerbase class to accept and handle thehost_urlparameter, stripping trailing slashes and documenting its usage.Documentation Updates:
README.md. [1] [2]Testing Enhancements:
test_validators.py). Also updated validator metadata tests to include the new Databricks validator. [1] [2] [3]