Skip to content

Update cli.py#9

Closed
GorillaBearWolf wants to merge 1 commit into
advanced-security:mainfrom
GorillaBearWolf:patch/update-validity-filter
Closed

Update cli.py#9
GorillaBearWolf wants to merge 1 commit into
advanced-security:mainfrom
GorillaBearWolf:patch/update-validity-filter

Conversation

@GorillaBearWolf

Copy link
Copy Markdown

Change validity filter options to match https://docs.github.com/rest/secret-scanning/secret-scanning#list-secret-scanning-alerts-for-an-organization and https://docs.github.com/en/enterprise-cloud@latest/code-security/secret-scanning/managing-alerts-from-secret-scanning/evaluating-alerts#checking-a-secrets-validity

This update fixes the following error when using the --validity option:

"Error: Failed to fetch GitHub alerts: GitHub API error: 422 - {"message":"validity is invalid: it must be one of 'active', 'inactive', or 'unknown'","documentation_url":"https://docs.github.com/rest/secret-scanning/secret-scanning#list-secret-scanning-alerts-for-an-organization","status":"422"}"

Thanks for making the tool, I had started to build this from scratch this week!

@theztefan theztefan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for submitting the PR <3

@theztefan

Copy link
Copy Markdown
Collaborator

@GorillaBearWolf the Code scanning CodeQL results seems to be stuck. As this is required to merge, @aegilops was kind enough to open a copy of your suggestion in #10 which is now merged.

Thanks a lot for the contribution! Looking forward to the next one. 😉

@theztefan theztefan closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants