View permissions are bypassed for paginated lists of ORM data
Moderate severity
GitHub Reviewed
Published
Jan 22, 2024
in
silverstripe/silverstripe-graphql
•
Updated Jan 29, 2024
Package
Affected versions
>= 4.0.0, < 4.3.7
>= 5.0.0, < 5.1.3
Patched versions
4.3.7
5.1.3
Description
Published to the GitHub Advisory Database
Jan 23, 2024
Reviewed
Jan 23, 2024
Published by the National Vulnerability Database
Jan 23, 2024
Last updated
Jan 29, 2024
Impact
canView
permission checks are bypassed for ORM data in paginated GraphQL query results where the total number of records is greater than the number of records per page.Note that this also affects GraphQL queries which have a limit applied, even if the query isn’t paginated per se.
This has been fixed by ensuring no new records are pulled in from the database after performing
canView
permission checks for each page of results. This may result in some pages in your query results having less than the maximum number of records per page even when there are more pages of results.This behaviour is consistent with how pagination works in other areas of Silverstripe CMS, such as in
GridField
, and is a result of having to perform permission checks in PHP rather than in the database directly.You can choose to disable these permission checks by disabling the
CanViewPermission
plugin following the instructions in overriding default plugins.Note that this vulnerability does not affect version 3.x.
Base CVSS: 5.3
Reported by: Eduard Briem from Hothouse Creative, Nelson
References
https://www.silverstripe.org/download/security-releases/CVE-2023-44401
References