crayon: ObjectPool creates uninitialized memory when freeing objects
High severity
GitHub Reviewed
Published
Apr 5, 2024
to the GitHub Advisory Database
•
Updated Apr 5, 2024
Description
Published to the GitHub Advisory Database
Apr 5, 2024
Reviewed
Apr 5, 2024
Last updated
Apr 5, 2024
As of version 0.6.0, the ObjectPool explicitly creates an uninitialized instance of its type parameter when it attempts to free an object, and swaps it into the storage. This causes instant undefined behavior due to reading the uninitialized memory in order to write it to the pool storage.
Extremely basic usage of the crate can trigger this issue, e.g. this code from a doctest:
The Clippy warning for this code was silenced in commit c2fde19caf6149d91faa504263f0bc5cafc35de5.
Discovered via https://asan.saethlin.dev/ub?crate=crayon&version=0.7.1
References