Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Bookshelf loading indicators as toast notifications #1264

Open
Rdkang opened this issue Jul 19, 2024 · 0 comments · May be fixed by #1265
Open

[Enhancement]: Bookshelf loading indicators as toast notifications #1264

Rdkang opened this issue Jul 19, 2024 · 0 comments · May be fixed by #1265
Labels
enhancement New feature or request

Comments

@Rdkang
Copy link

Rdkang commented Jul 19, 2024 •
edited
Loading

Describe the Feature/Enhancement

To use toast notifications for the "Attempting server connection..." and "Loading server data..." messages instead of text above the bookshelf.

Why would this be helpful?

The current loading indicators causes the row of books to shift upwards after loading, which i find to be quite jarring.
By using toast notifications for the messages, it stops the layout shift.

Future Implementation (Screenshot)

(slowed to 20% to make it easier to see)

video.of.toast.notification.slowed.mp4

Audiobookshelf App Version

Android App - 0.9.74

Current Implementation (Screenshot)

(slowed to 20% to make it easier to see)

audiobookshelf-enchancement-recording.-.Copy.mp4
@Rdkang Rdkang added the enhancement New feature or request label Jul 19, 2024
@Rdkang Rdkang changed the title [Enhancement]: bookshelf loading indicators as toast notifications [Enhancement]: Bookshelf loading indicators as toast notifications Jul 19, 2024
@Rdkang Rdkang linked a pull request Jul 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Move Loading Indicators to Toast Notifications Rdkang/audiobookshelf-app
1 participant
@Rdkang