Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Loading Indicators to Toast Notifications #1265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rdkang
Copy link

@Rdkang Rdkang commented Jul 19, 2024

resolves #1264

Video of changes
(slowed to 20% to make it easier to see)

video.of.toast.notification.slowed.mp4

Copy link

@ISO-B ISO-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine.

Tested with Oneplus One Android 11

@nichwall
Copy link
Contributor

Would it make more sense to move this from being part of the icon in the top bar, where users can tap to see what state the app is in?

Screenshot_20240819-123154.png

I know at one point in the past someone mentioned reducing the amount of moving things (in general, not just this loading indicator).

I think these connect messages were originally shown there, but people were getting confused about what was actually happening, so I may just be saying to return to how it was before and we'll get the same sort of request to add more information.

@advplyr
Copy link
Owner

advplyr commented Aug 26, 2024

I think the toasts are more obtrusive then how it is now. We could return to putting a spinner in the appbar like @nichwall is saying without having text anywhere saying it is connecting.
Or we could go back to blocking user interaction until the server connection attempt is finished

@nichwall
Copy link
Contributor

I don't think blocking user input is a good option since there were a lot of complaints about that causing problems in poor service (since that would also prevent disconnecting from the server in the side menu).

I think just updating the connection widget to show "loading" would be good, since most people don't really care if it's still in the connecting or loading phase, only that it isn't complete. If it's taking a long time, they can tap on it to see which part it's stuck on.

@Rdkang
Copy link
Author

Rdkang commented Aug 26, 2024

I agree with the spinner in the app bar.

@advplyr are you able to implement this? If not I can in a week or two :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Bookshelf loading indicators as toast notifications
4 participants